Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: using invoker commands #3323

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

refactor: using invoker commands #3323

wants to merge 4 commits into from

Conversation

mfranzke
Copy link
Member

Proposed changes

Resolves #3322

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke
refactor: buttons shouldn't open content before them
7b23b57 
SR users need related content to be after buttons and not before (might be ok due to dialog role)
@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Oct 17, 2024
@mfranzke mfranzke added this to the v0.6.0 milestone Oct 17, 2024
@mfranzke mfranzke self-assigned this Oct 17, 2024
@mfranzke mfranzke linked an issue Oct 17, 2024 that may be closed by this pull request
Introduce invoker commands instead of JS glue code #3322
Open
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/3322-introduce-invoker-commands-instead-of-js-glue-code

@github-actions github-actions bot added 📕documentation Improvements or additions to documentation 🏘components Changes inside components folder labels Oct 17, 2024
@mfranzke
refactor: buttons shouldn't open content before them
6ed2b71 
SR users need related content to be after buttons and not before (might be ok due to dialog role)
@github-actions github-actions bot added the 📺showcases Changes to 1-n showcases label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget Awaiting requested review from nmerget nmerget will be requested when the pull request is marked ready for review nmerget is a code owner

@annsch annsch Awaiting requested review from annsch annsch will be requested when the pull request is marked ready for review annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch will be requested when the pull request is marked ready for review bruno-sch is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@mfranzke mfranzke

Labels
🏘components Changes inside components folder 📕documentation Improvements or additions to documentation 🍄🆙improvement New feature or request 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

Introduce invoker commands instead of JS glue code
1 participant
@mfranzke