[#113] Filter workers by their last job status #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rhian-cs Would u mind posting a print screen of the final result? |
wenderjean
reviewed
Feb 12, 2021
There was a problem hiding this comment.
@rhian-cs Can u add the changes you're adding in the CHANGELOG.md file?
| /* === INPUT LIST === */ | ||
|
|
||
| #status_filters_checkboxes { | ||
| display: flex; |
There was a problem hiding this comment.
Would you mind keeping an indentation of 2 spaces?
| end | ||
|
|
||
| def filter_last_job_status(status) | ||
| display.select { |worker| worker[:last_job_status] == status } |
There was a problem hiding this comment.
Can u try to feed a huge number of data into Redis just to allow us to identify performance issues here?
ScreenshotsShowing only the workers table and the difference when each checkbox is ticked. Both Passed and Failed workers
Only Passed workers
Only Failed workers
No checkboxes ticked
|
added 10 commits
May 31, 2023 12:21
…nce and updating its tests
rhian-cs
force-pushed
the
filter-workers-by-state
branch
from
1323320
to
00d7c93
Compare
|
@wenderjean @davydovanton Hey everyone! I just rebased this PR and fixed the conflicts. When you have a bit of time, would you mind reviewing it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a way to filter workers by their last_job_status properties (as requested in #113) both in the API and in the statistics web page. Tests for the API and the called methods are also included.
API:
/sidekiq/api/statistic_by_last_job_status.jsonWeb page
In
/sidekiq/statisticWorker's table I added two checkboxes (Passed and Failed) to show/hide the workers in the table depending on their last job status.