fix: sort values before the shift function (#151)

* Sort values before the shift function * Changing version to 0.12.0
david26694 · Feb 6, 2024 · f006174 · f006174
1 parent 6c22bff
commit f006174
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/cluster_experiments/washover.py b/cluster_experiments/washover.py
@@ -148,7 +148,8 @@ def washover(
         # Cluster columns that do not involve time
         non_time_cols = list(set(cluster_cols) - set([truncated_time_col]))
         # For each cluster, we need to check if treatment has changed wrt last time
-        df_agg = df.drop_duplicates(subset=cluster_cols + [treatment_col]).copy()
+        df_agg = df.sort_values([original_time_col]).copy()
+        df_agg = df_agg.drop_duplicates(subset=cluster_cols + [treatment_col])
         df_agg["__changed"] = (
             df_agg.groupby(non_time_cols)[treatment_col].shift(1)
             != df_agg[treatment_col]

diff --git a/setup.py b/setup.py
@@ -47,7 +47,7 @@
 
 setup(
     name="cluster_experiments",
-    version="0.11.0",
+    version="0.12.0",
     packages=find_packages(),
     extras_require={
         "dev": dev_packages,