Add support for Platform.sh #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeledy
force-pushed
the
platformsh
branch
2 times, most recently
from
b833432
to
b793418
Compare
|
@davereid The code climate action won't be able to complete successfully because CC_TEST_REPORTER_ID will be empty since secrets aren't available to PRs coming from a forked repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2
Platform.sh allows a user to create their own environments with arbitrary names. It also allows a user to define the type of environment that it is (development, staging, production). The names and types are available in environment variables. I opted to have
getEnvironment()always return the user-defined environment name and introduce a newgetEnvironmentType()method to the PlatformSh class to be used byisProduction()and the like to get the type of environment.Neither Lando nor DDEV supply the environment type variable, so I defaulted to "local" when it is not present.