Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Platform.sh #2

Open
davereid opened this issue Jun 27, 2023 · 3 comments · May be fixed by #4
Open

Support Platform.sh #2

davereid opened this issue Jun 27, 2023 · 3 comments · May be fixed by #4

Comments

@davereid
Copy link
Owner

No description provided.

@AaronFeledy AaronFeledy linked a pull request Jul 1, 2023 that will close this issue
Open
@UltraBob
Copy link

UltraBob commented Apr 2, 2024

Are there any plans to review AaronFeledy's PR for this?

@AaronFeledy
Copy link

@UltraBob If Dave doesn't have any viable test projects running on Platform at the moment, he may not be able to test the PR himself. I'd say test it if you haven't already and comment your findings on the #4 thread. Community feedback may help move it forward.

@UltraBob
Copy link

Fair point. We ported the same logic into our own environment detection code, and it works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for Platform.sh AaronFeledy/drupal-environment
3 participants
@UltraBob @davereid @AaronFeledy