Fix ignoring of gutter clicks when debugger not active #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check didn't check whether the **current** window has debugger active so debuggers active in other windows enabled gutter click in the current window also.
rchl
changed the title
|
This conflicts with how breakpoints are currently displayed which can lead to a breakpoint that appears in a gutter but cannot be removed/edited. Breakpoints are displayed on every view with the correct file name regardless of if the view has the same window as the debugger in which the breakpoint was set. |
|
But with a single window with no debugger active, or with multiple windows of which neither has debugger active, the issue you mention would still happen, right? So this change would make things more consistent at least. Unless I'm missing something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check didn't check whether the current window has debugger
active so debuggers active in other windows enabled gutter clicks
in the current window also.
Relates to #68