-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the read me to include more details about the cqlsh_host con… #107
Open
AndrewHogg
wants to merge
1
commit into
master
Choose a base branch
from
andrew/localhost-issue
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -204,6 +204,16 @@ sed -i 's/^#?skipS3=.*/skipS3=\"true\"/' | |
sed -i 's/^#?keepArtifact=.*/keepArtifact=\"true\"/' | ||
``` | ||
|
||
* If the script fails when attempting to run the `cqlsh` command due to an incorrect host address, an additional configuration item can be uncommented and used to supply a suitable host value. The default behaviour of the setting is that a node will use the `hostname` command to provide the address to use as it is run on the node. Problems occur if this hostname does not resolve to the IP address that the node is listening for connections on. An alternative command can be used instead, which is supplied via configuration. | ||
|
||
An example of a replacement when running on AWS to use the local private IP is: | ||
|
||
``` | ||
cqlsh_host="$(curl http://169.254.169.254/latest/meta-data/local-ipv4)" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. have we tested this works in the configuration file? if it does, this it would make more sense that the line https://github.com/datastax/diagnostic-collection/blob/master/ds-collector/collector.conf.in#L139
|
||
``` | ||
|
||
This will ensure that each node uses it's own internal IP address as the `cqlsh` host address. | ||
|
||
|
||
What is Collected | ||
================= | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to make mention that it is recommended and normal to first configure
cqlHost
.that this is only needed when the hostname cannot be a standard ip/hostname on all nodes, and not
$(hostname)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still curious if this comment/info is better here or here: https://github.com/datastax/diagnostic-collection/blob/master/ds-collector/collector.conf.in#L139