Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support no cache and pull options for dockerized --build #51

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

boukeversteegh
Copy link
Contributor

No description provided.

@boukeversteegh
Copy link
Contributor Author

@danielrolfes2307 @drolfes

This feature was quite simple to implement. Could you check out this branch, and see if it works the way you expected?

Suggested method of running:

# unix
DOCKERIZED_ROOT=$PWD go run main.go --build --no-cache --pull <COMMAND>

or

# powershell
$env:DOCKERIZED_ROOT = $(Get-Location) ; go run main.go --build --no-cache --pull <COMMAND>

Fixes #52

@danielrolfes2307
Copy link

@boukeversteegh
Awesome...Will try later and give feedback :)

@boukeversteegh
Copy link
Contributor Author

By the way, this PR does not include your request of running build without run, so the main question is whether the flags actually work as expected.

@danielrolfes2307
Copy link

@boukeversteegh
Sorry for the late reply. I tested it and it works as expected :)

@boukeversteegh boukeversteegh merged commit 79f19ae into master Jul 17, 2023
13 checks passed
@boukeversteegh boukeversteegh deleted the feature/build-options branch July 17, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants