Added the version info #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
alaGarbey675
commented
Oct 8, 2024
alaGarbey675
commented
- Made the "in progress" status color lighter.
- Added the version of the application
Bumps [github.com/mattn/go-sqlite3](https://github.com/mattn/go-sqlite3) from 1.14.23 to 1.14.24. - [Release notes](https://github.com/mattn/go-sqlite3/releases) - [Commits](mattn/go-sqlite3@v1.14.23...v1.14.24) --- updated-dependencies: - dependency-name: github.com/mattn/go-sqlite3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
This commit also contains an update on the intensity of the orange color for the 'in progress' status.
bart6114
reviewed
Oct 8, 2024
There was a problem hiding this comment.
added some comments
can we also
- make these to be size
text-xs(tailwind)cheek/pkg/web_assets/templates/base.html
Line 38 in abdddf7
- add the ci logic to set the build flags for the version/sha at buildtime
Thanks!
|
build flags : go build -ldflags="-X 'github.com/datarootsio/cheek/pkg.Version=${{ needs.version_tag.outputs.new_tag }}' -X 'github.com/datarootsio/cheek/pkg.CommitSHA=${{ steps.vars.outputs.sha_short }}'" |
bart6114
reviewed
Oct 9, 2024
.github/workflows/ci.yml
Outdated
| @@ -86,7 +86,7 @@ jobs: | |||
| - id: vars | |||
| run: echo "::set-output name=sha_short::$(git rev-parse --short HEAD)" | |||
| - run: mkdir -p ${{ matrix.goos }}/${{ matrix.goarch }} | |||
| - run: env GOOS=${{ matrix.goos }} GOARCH=${{ matrix.goarch }} go build -ldflags="-X 'github.com/datarootsio/cheek/pkg.Version=${{ steps.vars.outputs.sha_short }}'" -o ${{ matrix.goos }}/${{ matrix.goarch }} | |||
| - run: env GOOS=${{ matrix.goos }} GOARCH=${{ matrix.goarch }} go build -ldflags="-X 'github.com/datarootsio/cheek/pkg.Version=${{ steps.vars.outputs.sha_short }}' -X 'github.com/datarootsio/cheek/pkg.CommitSHA=${{ steps.vars.outputs.sha_short }}'" -o ${{ matrix.goos }}/${{ matrix.goarch }} | |||
There was a problem hiding this comment.
this will set both values to the commit has (sha), but the pkg.Version so be something like needs.version_tag.outputs.new_tag, right?
added 2 commits
October 9, 2024 14:12
…/mattn/go-sqlite3-1.14.24' into adding-in-progress-status
|
Thank you @alaGarbey675 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.