Import API and/or web source url for bill #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgregg
requested changes
Feb 11, 2019
| for source in bill_info['sources']: | ||
| if source['note'] == 'web': | ||
| if source['note'] == 'api': |
There was a problem hiding this comment.
if i'm reading this correctly, if there is both an api source and a web source, this code will prefer the api source. I think we want the opposite behavior, don't we?
There was a problem hiding this comment.
Oh, I was thinking we'd want the API source, but actually we should return the web url, since that gets rendered in some of Councilmatic display logic. Okee.
fgregg
approved these changes
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles issue #227
It also prepares for scraper changes: opencivicdata/scrapers-us-municipal#259