Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source_url does not necessarily align with source_note #227

Open
reginafcompton opened this issue Jan 18, 2019 · 0 comments
Open

source_url does not necessarily align with source_note #227

reginafcompton opened this issue Jan 18, 2019 · 0 comments

Comments

@reginafcompton
Copy link
Contributor

We add the source_url by looking for the link to the web interface (rather than the api - might be worth asking why?):
https://github.com/datamade/django-councilmatic/blob/master/councilmatic_core/management/commands/import_data.py#L954

However, the source_note (determined by looking at the 0th position in sources) does not necessarily return "web." https://github.com/datamade/django-councilmatic/blob/master/councilmatic_core/management/commands/import_data.py#L992

(n.b., hopefully, issues like these will be resolved, upon implementation of isolated databases – documenting the issue, nonetheless)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant