Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 02-common-mistakes.md #167

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Conversation

laurasootes
Copy link
Contributor

To solve #160 I replaced the html table by a common markdown table, while keeping the contents the same.
This fixes the problem that the table was rendered within the next header line

Fix render mistake in table
@github-actions
Copy link

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

Copy link
Contributor

@bencomp bencomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @laurasootes! I have just a few small suggestions for the header row.

episodes/02-common-mistakes.md Outdated Show resolved Hide resolved
Co-authored-by: Ben Companjen <[email protected]>
Copy link
Contributor

@bencomp bencomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course my review is biased, but I'm happy anyway. Hopefully the maintainers are also happy with these changes.

@josenino95 josenino95 merged commit fcda37f into datacarpentry:main Jun 27, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Jun 27, 2024
Auto-generated via {sandpaper}
Source  : fcda37f
Branch  : main
Author  : Jose Niño <[email protected]>
Time    : 2024-06-27 21:38:49 +0000
Message : Merge pull request #167 from laurasootes/patch-1

Update 02-common-mistakes.md
github-actions bot pushed a commit that referenced this pull request Jun 27, 2024
Auto-generated via {sandpaper}
Source  : bb1cf4b
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-27 21:39:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : fcda37f
Branch  : main
Author  : Jose Niño <[email protected]>
Time    : 2024-06-27 21:38:49 +0000
Message : Merge pull request #167 from laurasootes/patch-1

Update 02-common-mistakes.md
@josenino95
Copy link
Contributor

Thank you @bencomp and @laurasootes for taking care of this a while ago. I just merged PRs #167 and #171

@bencomp
Copy link
Contributor

bencomp commented Jun 28, 2024

Thanks, @josenino95. Could you close #160 too, now that this fixed it?

github-actions bot pushed a commit that referenced this pull request Jul 2, 2024
Auto-generated via {sandpaper}
Source  : bb1cf4b
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-27 21:39:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : fcda37f
Branch  : main
Author  : Jose Niño <[email protected]>
Time    : 2024-06-27 21:38:49 +0000
Message : Merge pull request #167 from laurasootes/patch-1

Update 02-common-mistakes.md
github-actions bot pushed a commit that referenced this pull request Jul 9, 2024
Auto-generated via {sandpaper}
Source  : bb1cf4b
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-27 21:39:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : fcda37f
Branch  : main
Author  : Jose Niño <[email protected]>
Time    : 2024-06-27 21:38:49 +0000
Message : Merge pull request #167 from laurasootes/patch-1

Update 02-common-mistakes.md
github-actions bot pushed a commit that referenced this pull request Jul 16, 2024
Auto-generated via {sandpaper}
Source  : bb1cf4b
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-27 21:39:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : fcda37f
Branch  : main
Author  : Jose Niño <[email protected]>
Time    : 2024-06-27 21:38:49 +0000
Message : Merge pull request #167 from laurasootes/patch-1

Update 02-common-mistakes.md
github-actions bot pushed a commit that referenced this pull request Jul 23, 2024
Auto-generated via {sandpaper}
Source  : bb1cf4b
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-27 21:39:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : fcda37f
Branch  : main
Author  : Jose Niño <[email protected]>
Time    : 2024-06-27 21:38:49 +0000
Message : Merge pull request #167 from laurasootes/patch-1

Update 02-common-mistakes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants