-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 02-common-mistakes.md #167
Conversation
Fix render mistake in table
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits. It should be safe to Approve and Run the workflows that need maintainer approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @laurasootes! I have just a few small suggestions for the header row.
Co-authored-by: Ben Companjen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course my review is biased, but I'm happy anyway. Hopefully the maintainers are also happy with these changes.
Auto-generated via {sandpaper} Source : fcda37f Branch : main Author : Jose Niño <[email protected]> Time : 2024-06-27 21:38:49 +0000 Message : Merge pull request #167 from laurasootes/patch-1 Update 02-common-mistakes.md
Auto-generated via {sandpaper} Source : bb1cf4b Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-27 21:39:26 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : fcda37f Branch : main Author : Jose Niño <[email protected]> Time : 2024-06-27 21:38:49 +0000 Message : Merge pull request #167 from laurasootes/patch-1 Update 02-common-mistakes.md
Thank you @bencomp and @laurasootes for taking care of this a while ago. I just merged PRs #167 and #171 |
Thanks, @josenino95. Could you close #160 too, now that this fixed it? |
Auto-generated via {sandpaper} Source : bb1cf4b Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-27 21:39:26 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : fcda37f Branch : main Author : Jose Niño <[email protected]> Time : 2024-06-27 21:38:49 +0000 Message : Merge pull request #167 from laurasootes/patch-1 Update 02-common-mistakes.md
Auto-generated via {sandpaper} Source : bb1cf4b Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-27 21:39:26 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : fcda37f Branch : main Author : Jose Niño <[email protected]> Time : 2024-06-27 21:38:49 +0000 Message : Merge pull request #167 from laurasootes/patch-1 Update 02-common-mistakes.md
Auto-generated via {sandpaper} Source : bb1cf4b Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-27 21:39:26 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : fcda37f Branch : main Author : Jose Niño <[email protected]> Time : 2024-06-27 21:38:49 +0000 Message : Merge pull request #167 from laurasootes/patch-1 Update 02-common-mistakes.md
Auto-generated via {sandpaper} Source : bb1cf4b Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-27 21:39:26 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : fcda37f Branch : main Author : Jose Niño <[email protected]> Time : 2024-06-27 21:38:49 +0000 Message : Merge pull request #167 from laurasootes/patch-1 Update 02-common-mistakes.md
To solve #160 I replaced the html table by a common markdown table, while keeping the contents the same.
This fixes the problem that the table was rendered within the next header line