Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter] **Breaking change** Use new query and alert resources instead of legacy resources #4150

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Oct 24, 2024

Changes

This change replaces legacy databricks_sql_query and databricks_sql_alert with new resources databricks_query and databricks_alert. Also, services sql-queries and sql-alerts are renamed to queries and alerts.

Other changes include:

  • Improve performance of Lakeview dashboards scan by using bigger page size
  • Generalize isMatchingCatalogAndSchema implementation for use in multiple resources where attribute names could be different
  • Generalize handling of /Workspace prefix when emitting notebooks, workspace files and directories.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

…tead of legacy ones

This change replaces legacy `databricks_sql_query` and `databricks_sql_alert` with new
resources `databricks_query` and `databricks_alert`.  Also, services `sql-queries` and
`sql-alerts` are renamed to `queries` and `alerts`.

Other changes include:

* Improve performance of Lakeview dashboards scan by using bigger page size
* Generalize `isMatchingCatalogAndSchema` implementation for use in multiple resources
  where attribute names could be different
* Generalize handling of `/Workspace` prefix when emitting notebooks, workspace files and
  directories.
@alexott alexott requested review from a team as code owners October 24, 2024 11:57
@alexott alexott requested review from parthban-db and removed request for a team October 24, 2024 11:57
@alexott alexott added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit faa6a89 Oct 24, 2024
9 checks passed
@alexott alexott deleted the exporter/queries-alerts-support branch October 24, 2024 12:50
@eng-dev-ecosystem-bot
Copy link
Collaborator

Test status: success
Commit SHA: b4dcf34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants