Add support for installing the CLI on DBR #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietern
reviewed
Feb 6, 2024
shreyas-goenka
changed the title
andrewnester
approved these changes
Feb 22, 2024
| run: ./setup-cli/install.sh | ||
| shell: bash | ||
| env: | ||
| DATABRICKS_RUNTIME_VERSION: value-does-not-matter |
There was a problem hiding this comment.
Is this env variable always set on DBR?
There was a problem hiding this comment.
While it's not documented to be guaranteed, it's been present on all clusters I have tried out and is very well-established as a rubric to detect that code is being run from DBR.
For example, Mlflow also uses the same check here
https://github.com/mlflow/mlflow/blob/30462203357010cba51d743a96c0cae5397e7e1b/mlflow/utils/databricks_utils.py#L180
There was a problem hiding this comment.
pietern
reviewed
Feb 26, 2024
shreyas-goenka
added a commit
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to install the CLI at $HOME/bin when the
install.shinstallation script is invoked from DBR. This allows us to provide the CLI in DBR though a proxy trampoline script that's installed in DBR at/usr/local/bin.This PR also adds a couple of tests and assertions to make this functionality robust for use in DBR.