Add bundle generate variant for dashboards #1847
Draft
+476
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return nil | ||
| } | ||
|
|
||
| func (d *dashboard) generateForResource(ctx context.Context, b *bundle.Bundle) diag.Diagnostics { |
There was a problem hiding this comment.
Naming is a bit confusing to me, maybe better call it continiouslyUpdateResource or so?
| // Start polling the underlying dashboard for changes. | ||
| var etag string | ||
| for { | ||
| w := b.WorkspaceClient() |
There was a problem hiding this comment.
you can move it out of for loop
|
|
||
| // Now poll the workspace API for changes. | ||
| // This is much more efficient than polling the dashboard API. | ||
| for { |
There was a problem hiding this comment.
maybe better abstract it into separate waitForChanges func?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Work on
databricks bundle generatecommand for dashboards.Tests
todo