Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added validator for folder permissions #1824

Merged
merged 10 commits into from
Oct 24, 2024

Conversation

andrewnester
Copy link
Contributor

@andrewnester andrewnester commented Oct 10, 2024

Changes

This validator checks permissions defined in top-level bundle config and permissions set in workspace for the folders bundle is deployed to. It raises the warning if the permissions defined in the workspace are not defined in bundle.

This validator is executed only during bundle validate command.

Tests

Warning: untracked permissions apply to target workspace path

The following permissions apply to the workspace folder at "/Workspace/Users/[email protected]/.bundle/clusters/default" but are not configured in the bundle:
- level: CAN_MANAGE, user_name: [email protected]

bundle/config/validate/folder_permissions.go Outdated Show resolved Hide resolved
bundle/config/validate/folder_permissions.go Outdated Show resolved Hide resolved
bundle/config/validate/folder_permissions.go Outdated Show resolved Hide resolved
bundle/config/validate/folder_permissions.go Outdated Show resolved Hide resolved
bundle/config/validate/folder_permissions.go Show resolved Hide resolved
bundle/config/validate/folder_permissions.go Outdated Show resolved Hide resolved
bundle/config/validate/folder_permissions.go Outdated Show resolved Hide resolved
bundle/config/validate/folder_permissions.go Outdated Show resolved Hide resolved
bundle/config/validate/folder_permissions.go Outdated Show resolved Hide resolved
bundle/config/validate/folder_permissions.go Show resolved Hide resolved
bundle/config/validate/folder_permissions.go Outdated Show resolved Hide resolved
bundle/config/validate/folder_permissions.go Show resolved Hide resolved
bundle/config/validate/folder_permissions.go Show resolved Hide resolved
bundle/permissions/check.go Outdated Show resolved Hide resolved
bundle/permissions/check.go Outdated Show resolved Hide resolved
bundle/permissions/check.go Outdated Show resolved Hide resolved
bundle/permissions/check.go Outdated Show resolved Hide resolved
bundle/permissions/check.go Outdated Show resolved Hide resolved
bundle/config/validate/folder_permissions.go Outdated Show resolved Hide resolved
bundle/config/validate/folder_permissions_test.go Outdated Show resolved Hide resolved
bundle/config/validate/folder_permissions_test.go Outdated Show resolved Hide resolved
bundle/config/validate/folder_permissions_test.go Outdated Show resolved Hide resolved
bundle/permissions/check.go Outdated Show resolved Hide resolved
bundle/permissions/check.go Outdated Show resolved Hide resolved
bundle/permissions/check.go Outdated Show resolved Hide resolved
bundle/config/resources/permission.go Show resolved Hide resolved
bundle/config/validate/folder_permissions.go Show resolved Hide resolved
bundle/permissions/check.go Outdated Show resolved Hide resolved
bundle/permissions/check.go Outdated Show resolved Hide resolved
bundle/permissions/check.go Outdated Show resolved Hide resolved
bundle/permissions/check.go Outdated Show resolved Hide resolved
Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining things:

@andrewnester andrewnester added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit eaea308 Oct 24, 2024
5 checks passed
@andrewnester andrewnester deleted the feature/validate-folder-permissions branch October 24, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants