Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding covering grid support #120

Merged
merged 8 commits into from
Apr 3, 2024

Conversation

chrishavlin
Copy link
Collaborator

@chrishavlin chrishavlin commented Jan 30, 2024

allows you to load in derived fields that require ghost zones (like divergence fields)

Closes #99

To do:

  • tests
  • Timeseries support
  • update notebook interface

@chrishavlin chrishavlin added bug Something isn't working enhancement New feature or request labels Jan 30, 2024
@chrishavlin chrishavlin marked this pull request as draft January 31, 2024 20:21
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: Patch coverage is 98.60140% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 99.58%. Comparing base (2e0c83c) to head (5b7b239).
Report is 9 commits behind head on main.

Files Patch % Lines
src/yt_napari/viewer.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
- Coverage   99.64%   99.58%   -0.06%     
==========================================
  Files          31       32       +1     
  Lines        2542     2670     +128     
==========================================
+ Hits         2533     2659     +126     
- Misses          9       11       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrishavlin chrishavlin changed the title [WIP] adding covering grid support adding covering grid support Apr 3, 2024
@chrishavlin chrishavlin marked this pull request as ready for review April 3, 2024 14:14
@chrishavlin chrishavlin merged commit 3d390d3 into data-exp-lab:main Apr 3, 2024
15 checks passed
@chrishavlin chrishavlin added this to the v0.5.0 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yt fields that require ghost zones error
1 participant