refactor(controller, instrumenter): extract instrumentation logic #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmanciop
approved these changes
Aug 19, 2024
cmd/main.go
Outdated
| Recorder: mgr.GetEventRecorderFor("dash0-controller"), | ||
| Images: images, | ||
| OTelCollectorBaseUrl: oTelCollectorBaseUrl, | ||
| } | ||
| go func() { | ||
| time.Sleep(10 * time.Second) |
There was a problem hiding this comment.
The sleep is a workaround for the following issue:
- We need to kick this (
InstrumentAtStartup) off before we call mgr.Start(), becausemgr.Start()blocks. - If
InstrumentAtStartupruns right away, beforemgr.Start()has actually run, it will throw an error, since the Kubernetesclientthat we get from themgris not started yet.
As the PR description explains, the aim of this PR is get rid of this arbitrary 10 second sleep -- by using a dedicated Kubernetes client that is independent from mgr. I was working on that when you threw your latest PR over the wall :-)
There was a problem hiding this comment.
The sleep is gone now, as well as the goroutine -- which was the ultimate goal of the PR.
basti1302
force-pushed
the
extract-instrumentation-machinery-to-separate-module
branch
2 times, most recently
from
615b9a0
to
54ee987
Compare
basti1302
force-pushed
the
extract-instrumentation-machinery-to-separate-module
branch
from
54ee987
to
f44d111
Compare
Extract the controller's instrumentation logic into a separate module, called instrumentation/instrumenter. This allows running the InstrumentAtStartup task with a separate client and to move it into executeStartupTasks; getting rid of the arbitrary (and potentially problematic) 10 second wait, which we previously needed to wait until the manager had finished initializing its Kubernetes API client.
basti1302
force-pushed
the
extract-instrumentation-machinery-to-separate-module
branch
from
f44d111
to
8f0e756
Compare
|
basti1302
deleted the
extract-instrumentation-machinery-to-separate-module
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the controller's instrumentation logic into a separate module, called instrumentation/instrumenter. This will facilitate running the InstrumentAtStartup task with a separate client and ultimately move it into executeStartupTasks, getting rid of the arbitrary (and potentially problematic) 10 second wait.