feat: remove cert-manager as dependency & support HTTP/HTTPs endpoints #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmanciop
force-pushed
the
no-cert-manager
branch
4 times, most recently
from
18136a4
to
8a600d6
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| seccompProfile: | ||
| type: RuntimeDefault | ||
| serviceAccountName: {{ template "dash0-operator.serviceAccountName" . }} | ||
| automountServiceAccountToken: true |
Check warning
Code scanning / SonarCloud
Service account tokens should not be mounted in pods
images/collector/Dockerfile
Outdated
|
|
||
| RUN apk add --update make git && apk cache clean | ||
|
|
||
| ADD ./src /src |
Check notice
Code scanning / SonarCloud
Prefer COPY over ADD for copying local resources
mmanciop
force-pushed
the
no-cert-manager
branch
from
a5c5115
to
ae2c19d
Compare
mmanciop
force-pushed
the
no-cert-manager
branch
from
67227e7
to
9f94209
Compare
basti1302
requested changes
Aug 13, 2024
helm-chart/dash0-operator/tests/operator/deployment-and-webhook_test.yaml
Outdated
Show resolved
Hide resolved
helm-chart/dash0-operator/templates/operator/pre-delete-hook.yaml
Outdated
Show resolved
Hide resolved
basti1302
reviewed
Aug 13, 2024
basti1302
requested changes
Aug 13, 2024
internal/backendconnection/otelcolresources/otelcol_resources.go
Outdated
Show resolved
Hide resolved
basti1302
changed the title
basti1302
force-pushed
the
no-cert-manager
branch
2 times, most recently
from
214c46b
to
a679edd
Compare
Also: * remove e2e custom logic in operator * introduce otlp-sink to validate telemetry in e2e
basti1302
force-pushed
the
no-cert-manager
branch
from
a679edd
to
992d136
Compare
|
basti1302
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a self-signed certificate for the injector webhook, removing the need of cert-manager as dependency.