make export attribute optional in monitoring resource, fall back to operator configuration's export #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basti1302
force-pushed
the
eng-2323-operator-default-backend-connection
branch
from
de608af
to
56a347d
Compare
Use the export setting from the operator configuration resource as a fallback if the monitoring resource does not define an export.
basti1302
force-pushed
the
eng-2323-operator-default-backend-connection
branch
from
56a347d
to
52a8b31
Compare
* webhook package -> webhooks * dash0_webhook.go -> instrumentation_webhook.go
basti1302
changed the title
Reject monitoring resources without export if no operator configuration resource with an export is available.
Reject operator configuration resources with self-telemetry enabled that have no export configuration.
basti1302
force-pushed
the
eng-2323-operator-default-backend-connection
branch
from
f332c2b
to
d0d5fc7
Compare
remove backend settings from dash0 monitoring resource
basti1302
force-pushed
the
eng-2323-operator-default-backend-connection
branch
from
c4a827e
to
cb76606
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.