Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backendconnection): avoid host port conflicts #111

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

basti1302
Copy link
Member

No description provided.

That is, do not use the default OTel ports for the host ports of the
operator-managed OTel collector daemonset.

Also: Make grpc & http host ports configurable.
…orts

We are still deliberatly using non-standard host ports to avoid
conflicts. If we want to reintroduce making the ports configurable, we
will add the option to the new Dash0OperatorConfiguration resource
later.
@basti1302 basti1302 force-pushed the eng-2357-do-not-use-otel-collector-standard-ports branch from c0f863e to 59b88af Compare August 23, 2024 11:33
@basti1302 basti1302 force-pushed the eng-2357-do-not-use-otel-collector-standard-ports branch from f193ae3 to d783c41 Compare August 23, 2024 13:47
This ensures that traffic is routed to the collector pod on the same
node.
@basti1302 basti1302 force-pushed the eng-2357-do-not-use-otel-collector-standard-ports branch from d783c41 to 0d091ec Compare August 23, 2024 13:49
Copy link

sonarcloud bot commented Aug 23, 2024

@basti1302 basti1302 enabled auto-merge (rebase) August 23, 2024 13:52
@basti1302 basti1302 merged commit b542534 into main Aug 23, 2024
7 checks passed
@basti1302 basti1302 deleted the eng-2357-do-not-use-otel-collector-standard-ports branch August 23, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant