ci: remove changed files check #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would actually need to compare to the commit of the last _successful_ build, not just to the last commit. Otherwise it will skip builds although the latest code has not been built yet.
Apparently issue with the flaky tests (cronjob spans not found) was due to the test reading the wrong test ID from the file system, very probably because an outdated test ID was still present in the file system and the new cronjob pod had not yet written its test ID. After that the test would look for spans with the wrong query parameter.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would actually need to compare to the commit of the last successful build, not just to the last commit. Otherwise it will skip builds although the latest code has not been built yet.