Try removing isolate.kill() #2198
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
force-pushed
the
remove-isolate-kill
branch
from
4e0db3f
to
d65ea4d
Compare
Originally isolates were killed when the loader was closed as the runner is shutting down. There was no comment in the review about the specific reason for `isolate.kill()`. https://codereview.chromium.org//920703006 Later the kill was moved to when the test suite is done. There was no specific comment about the `isolate.kill()` changes. https://codereview.chromium.org//1206033004 No internal tests seem to be relying on this behavior, and nothing times out when it is removed. Check whether there are any tests on CI that validate this behavior.
natebosch
force-pushed
the
remove-isolate-kill
branch
from
d65ea4d
to
ef7c98d
Compare
|
After some internal discussion and thinking more about the intent in https://codereview.chromium.org//1206033004 this We should consider writing an integration test that uses the VM service to count how many isolates are active or something along those lines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally isolates were killed when the loader was closed as the runner
is shutting down. There was no comment in the review about the specific
reason for
isolate.kill(). https://codereview.chromium.org//920703006Later the kill was moved to when the test suite is done. There was no
specific comment about the
isolate.kill()changes.https://codereview.chromium.org//1206033004
No internal tests seem to be relying on this behavior, and nothing times
out when it is removed. I am unable to find a counter-example or a way
to write a test for this behavior, so remove it for now.