Support for enhanced parts #3892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There isn't _much_ for dartdoc to be concerned with. Dartdoc basically must be aware of an exports foud in a part, and there might be reasons to be concerned with imports coming from a part. In particular, dartdoc used to skip resolving all part files when searching for libraries, just as an optimization. Can't do that any more. This might not be a full implementation of enhanced parts support, but it sets up the basics.
|
CC @dart-lang/analyzer-team |
scheglov
approved these changes
Sep 30, 2024
lib/src/model/package_graph.dart
Outdated
| for (var exportedElement in libraryElement.libraryExports) { | ||
|
|
||
| var exported = [ | ||
| ...libraryElement.libraryExports, |
There was a problem hiding this comment.
Theoretically units provide all the exports and imports that can be in the library.
There was a problem hiding this comment.
Ah it looks like you're right; I didn't test this with new unit tests, but they look good. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There isn't much for dartdoc to be concerned with. Dartdoc basically must be aware of an exports foud in a part, and there might be reasons to be concerned with imports coming from a part. In particular, dartdoc used to skip resolving all part files when searching for libraries, just as an optimization. Can't do that any more.
This might not be a full implementation of enhanced parts support, but it sets up the basics.
Work towards #3893
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.