Add the support to pass user supplied actor_factory callable in ActorRuntime & ext/fastapi,flask #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksachdeva
force-pushed
the
user-supplied-actor-factory
branch
from
5ceeb0b
to
65b15c8
Compare
|
Please run |
Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: Kapil Sachdeva <[email protected]>
…Runtime & ext/fastapi,flask Signed-off-by: Kapil Sachdeva <[email protected]>
Signed-off-by: Kapil Sachdeva <[email protected]>
* Pin workflow SDK 0.4.1 in example Signed-off-by: Bernd Verst <[email protected]> * fix workflow dev version Signed-off-by: Bernd Verst <[email protected]> * fix workflow example dependency Signed-off-by: Bernd Verst <[email protected]> --------- Signed-off-by: Bernd Verst <[email protected]> Signed-off-by: Kapil Sachdeva <[email protected]>
* doc: document that users can self-assign issues Signed-off-by: KentHsu <[email protected]> * doc: reorder paragraph and update CONTRIBUTING.md Signed-off-by: KentHsu <[email protected]> --------- Signed-off-by: KentHsu <[email protected]> Co-authored-by: Elena Kolevska <[email protected]> Signed-off-by: Kapil Sachdeva <[email protected]>
Signed-off-by: Pieter de Bruin <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Kapil Sachdeva <[email protected]>
ksachdeva
force-pushed
the
user-supplied-actor-factory
branch
from
19c6f71
to
cacfd9e
Compare
Signed-off-by: Bernd Verst <[email protected]>
berndverst
approved these changes
Jun 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #714 +/- ##
==========================================
- Coverage 86.37% 86.15% -0.22%
==========================================
Files 79 79
Lines 4094 4169 +75
==========================================
+ Hits 3536 3592 +56
- Misses 558 577 +19 ☔ View full report in Codecov by Sentry. |
|
@holopin-bot @ksachdeva Thank you! |
|
Congratulations @ksachdeva, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzvb442509640cl6a4jfwb7f This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #713
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: