Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the "maybe extend" behaviour of extendMatrix() more appropriately. #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pratyai
Copy link
Contributor

@pratyai pratyai commented Feb 14, 2024

Currently, if the given SDDM has a very small diagonal, the extension does not happen, but the RHS is augmented anyway. This causes a crash.

Example:

using Laplacians
using Statistics
using SparseArrays
using LinearAlgebra

n = 5;
A = Laplacians.uni_chimera(5, 1) * 5;  # heavyweight connected graph
L = Laplacians.lap(A);
M = L + sparse(I, n, n) * eps(Float64);  # with lightweight extra diagonal value
params = Laplacians.ApproxCholParams(:deg, 2, 2);
f = Laplacians.approxchol_sddm(M; params = params, verbose = false);
b = randn(n); b .-= mean(b);

@show f(b)  # this used to crash

@pratyai pratyai marked this pull request as ready for review February 14, 2024 10:35
appropriately.

Currently, if the given SDDM has a very small diagonal, the extension
does not happen, but the RHS is augmented anyway. This causes a crash.
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 76.49%. Comparing base (9ec1c10) to head (f01326a).

Files Patch % Lines
src/solverInterface.jl 81.81% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   76.51%   76.49%   -0.03%     
==========================================
  Files          37       37              
  Lines        5596     5599       +3     
==========================================
+ Hits         4282     4283       +1     
- Misses       1314     1316       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants