Skip to content
This repository has been archived by the owner on Sep 16, 2020. It is now read-only.

Fix #247 - reverse horizontal swipe direction in RTL #301

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #247 - reverse horizontal swipe direction in RTL #301

wants to merge 1 commit into from

Conversation

hery
Copy link

@hery hery commented Oct 9, 2018

No description provided.

@hery hery mentioned this pull request Oct 9, 2018
Open
moonios5
moonios5 suggested changes Feb 27, 2020
View reviewed changes
Copy link

@moonios5 moonios5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we need to change line no. 408
from
"transform: [{ translateX: this._rubberBandEasing(posX, limit) }]"
to
"transform: [{ translateX:(_reactNative.I18nManager.isRTL? -1:1)*this._rubberBandEasing(posX, limit) }]"

AkshayP8140
AkshayP8140 suggested changes Feb 27, 2020
View reviewed changes
Copy link

@AkshayP8140 AkshayP8140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we need to change line no. 408
from
"transform: [{ translateX: this._rubberBandEasing(posX, limit) }]"
to
"transform: [{ translateX:(_reactNative.I18nManager.isRTL? -1:1)*this._rubberBandEasing(posX, limit) }]"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moonios5 moonios5 moonios5 requested changes

@AkshayP8140 AkshayP8140 AkshayP8140 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hery @moonios5 @AkshayP8140