fixes and improvements about connection password need detection #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The string 'fe_sendauth: ...' is just a part of the error message, so we must not check for equality.
The second argument passed to pg_connect() is expected to be a 'exit_on_failed: bool', but we were passing the connection string. So when the connection string is given by the user, it behaves similarly as passing True (non-empty string evaluates to True); on the other hand, if no connection string is passed, it evaluates to False, which disables the 'exit_on_failed' feature. In fact, this exit_on_failed parameter is never used by caller, so let's just remove it.
Psycopg 3 links exceptions to the underlying libpq PGconn object, which exposes a 'needs_password' property; exactly what we need and much more robust than parsing the error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #390 (first commit).