Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key binds to Jump for cycling through tabs and sites. #123

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

lindely
Copy link

@lindely lindely commented Aug 31, 2024

This PR adds key binds to Jump:

  • Pressing T will open or close the tags menu.
  • Pressing , , or will cycle through the tags when the tags menu is open.
  • When the tags menu is closed, the arrows will cycle through the sites.
  • and will both cycle back, whereas and will cycle forward.
  • Pressing Enter will activate the selected tag or site.
  • Pressing Escape will clear selections.
  • Pressing Ctrl followed by a number will open the site at that position. For example, Ctrl + 1 will open the site on the first tile, Ctrl + 2 the site on the second tile, and so on. The first ten tiles can be opened this way.

@daledavies
Copy link
Owner

Nice, thanks! Great idea I'll give it a whirl over the next few days, just had a quick look at the code on my phone and it looks good.

@lindely
Copy link
Author

lindely commented Aug 31, 2024

I just noticed I failed to test properly and found some small issues. A fix is on its way, though :-). The next commit will hopefully be solid.

@daledavies
Copy link
Owner

Awesome, no worries. Thanks again 😁

@lindely
Copy link
Author

lindely commented Aug 31, 2024

I committed the fixes. Thanks for taking an interest in the change!

@daledavies
Copy link
Owner

Thanks for taking an interest in Jump! 🙂

@lindely
Copy link
Author

lindely commented Aug 31, 2024

After careful consideration I added a final commit. When switching tags with the keys, it makes sense to start cycling from the active tag instead of always from the first one. I used it myself for a bit and like how it works. If you however dislike this approach, feel free to remove commit 6a5b203.

@lindely
Copy link
Author

lindely commented Sep 1, 2024

I forgot about the optional search box. With the last commit, the key binds play nice with it enabled. The escape key now also closes the search box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants