You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces a way to separate the python packages you need vs. the pinned dependencies.
The motivating factors to adopt this:
we can control when we upgrade Dagster versions for Hooli (so if there is a breaking change we're not quite ready to adopt, we can accept other PRs in the meantime).
We can see all of the python packages that are used (so if there are weird dependency issues we can see them in the requirements.txt, which acts as lockfile of sorts.
The Dockerfile builds deterministically (so if it built once it will always build).
It's useful to have a demonstration of how to do this in case customers want to see how we would use pinned dependencies
(later) we could likely skip the "build steps" if these files aren't updated, which would allow build to be much faster (< 1 minute vs. 8 minutes)
Why we might not want to
it's another step if you want to upgrade anything in Dagster+
you need Docker installed on your computer because uv pip sync is platform-specific (this is fine for every package except for Sling, which requires amd64 arch to be specified.
it's annoying if your setup.py would work across Python versions but are set to different versions (as we have in some of our Dockerfiles). The only way to solve this permanently would be multiple dockerfiles with all of our python distros.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a way to separate the python packages you need vs. the pinned dependencies.
The motivating factors to adopt this:
requirements.txt
, which acts as lockfile of sorts.Why we might not want to
uv pip sync
is platform-specific (this is fine for every package except for Sling, which requires amd64 arch to be specified.