Pass loading context through _blocking_batch_load #25377
+55
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 18, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
briantu
force-pushed
the
briantu/make-compute-subset-async
branch
from
206d74c
to
9291fd1
Compare
briantu
force-pushed
the
briantu/pass-loading-context-in-batch
branch
from
47d27bd
to
18a7084
Compare
briantu
force-pushed
the
briantu/make-compute-subset-async
branch
from
9291fd1
to
9be1378
Compare
briantu
force-pushed
the
briantu/pass-loading-context-in-batch
branch
from
18a7084
to
c6bd3cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This lets us use the loading_context for get_asset_status_cache_values, which saves us from needing to re-fetch the asset records in here again.
Copied from demo PR #25270
How I Tested These Changes
Perf test before/after