Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

claire/relation_identifier #25346

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

claire/relation_identifier #25346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions js_modules/dagster-ui/packages/ui-core/src/search/SearchResults.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ const iconForType = (type: SearchResultType | AssetFilterSearchResultType): Icon
return 'view_column';
case AssetFilterSearchResultType.ColumnTag:
return 'tag';
case AssetFilterSearchResultType.RelationIdentifier:
return 'link';
default:
assertUnreachable(type);
}
Expand All @@ -80,6 +82,8 @@ const assetFilterPrefixString = (type: AssetFilterSearchResultType): string => {
return 'Column';
case AssetFilterSearchResultType.ColumnTag:
return 'Column tag';
case AssetFilterSearchResultType.RelationIdentifier:
return 'Relation identifier';
default:
assertUnreachable(type);
}
Expand Down
4 changes: 3 additions & 1 deletion js_modules/dagster-ui/packages/ui-core/src/search/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export enum AssetFilterSearchResultType {
AssetGroup = 'AssetFilterSearchResultType.AssetGroup',
Column = 'AssetFilterSearchResultType.Column',
ColumnTag = 'AssetFilterSearchResultType.ColumnTag',
RelationIdentifier = 'AssetFilterSearchResultType.RelationIdentifier',
}

export function isAssetFilterSearchResultType(
Expand All @@ -47,7 +48,8 @@ export function isAssetFilterSearchResultType(
type === AssetFilterSearchResultType.Owner ||
type === AssetFilterSearchResultType.Tag ||
type === AssetFilterSearchResultType.Column ||
type === AssetFilterSearchResultType.ColumnTag
type === AssetFilterSearchResultType.ColumnTag ||
type === AssetFilterSearchResultType.RelationIdentifier
);
}

Expand Down