[ui] Update eslint and TS in most of the dagster-ui workspace #25317
Conversation
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hellendag and the rest of your teammates on |
hellendag
force-pushed
the
dish/update-lint-ts
branch
from
b7831b9
to
0519676
Compare
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit eb4161f. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit eb4161f. |
hellendag
force-pushed
the
dish/update-lint-ts
branch
from
0519676
to
eb4161f
Compare
| "eslint-plugin-jest": "^26.4.6", | ||
| "eslint-plugin-prettier": "^5.0.0", | ||
| "eslint-plugin-unused-imports": "^4.1.4", |
There was a problem hiding this comment.
These started showing up as missing during lint runs, since they were only in the eslint-config's node_modules. I'm not sure why this worked without enumerating these deps before, but I think we were just getting lucky with packages ending up in the workspace-level node_modules.
| @@ -1,10 +1,10 @@ | |||
| import React from 'react'; | |||
|
|
|||
| import {ApolloClient, gql, useApolloClient} from '../apollo-client'; | |||
There was a problem hiding this comment.
Not sure why these are getting reordered this way, but it's autofixed so I'm going with it.
Summary & Motivation
Update TS and run lint in app-oss and ui-core, picking up fixes that are surfaced by the recent change to our eslint-config.
ui-components will be done in a followup, since it references the published eslint-config package.
How I Tested These Changes
make ts,make lintin dagster-ui.