Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dagster-tableau] Update docs with refreshable workbooks and materialization #24864

Merged
merged 12 commits into from
Oct 18, 2024
Merged

[dagster-tableau] Update docs with refreshable workbooks and materialization #24864

merged 12 commits into from
Oct 18, 2024

Conversation

maximearmstrong
Copy link
Contributor

@maximearmstrong maximearmstrong commented Sep 27, 2024 •
edited
Loading

Summary & Motivation

As title.

How I Tested These Changes

Docs preview

Changelog

NOCHANGELOG

@maximearmstrong maximearmstrong mentioned this pull request Sep 27, 2024
Merged
3 tasks
@maximearmstrong Graphite App
Copy link
Contributor Author

maximearmstrong commented Sep 27, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @maximearmstrong and the rest of your teammates on Graphite Graphite

@maximearmstrong maximearmstrong mentioned this pull request Sep 27, 2024
Merged
@maximearmstrong maximearmstrong self-assigned this Sep 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 27, 2024 •
edited
Loading

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-oa300fprt-elementl.vercel.app
https://maxime-update-tableau-docs-with-refresh-and-materialization.dagster.dagster-docs.io

Direct link to changed pages:

@maximearmstrong maximearmstrong marked this pull request as ready for review September 30, 2024 20:02
@graphite-app graphite-app bot added the area: docs Related to documentation in general label Sep 30, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 30, 2024

Graphite Automations

"Label and add CE on all Docs" took an action on this PR • (09/30/24)

2 reviewers were added and 1 label was added to this PR based on Pedram Navid's automation.

PedramNavid
PedramNavid previously requested changes Oct 1, 2024
View reviewed changes
docs/content/integrations/tableau.mdx Outdated Show resolved Hide resolved
docs/content/integrations/tableau.mdx Outdated Show resolved Hide resolved
docs/content/integrations/tableau.mdx Outdated Show resolved Hide resolved
@maximearmstrong maximearmstrong force-pushed the maxime/implement-tableau-refreshable-workbooks branch from dca7f72 to 7cefd11 Compare October 2, 2024 19:12
@maximearmstrong maximearmstrong force-pushed the maxime/update-tableau-docs-with-refresh-and-materialization branch from 5ae5552 to fb3baa3 Compare October 2, 2024 19:12
@maximearmstrong maximearmstrong force-pushed the maxime/implement-tableau-refreshable-workbooks branch from 7cefd11 to f764c68 Compare October 2, 2024 19:39
@maximearmstrong maximearmstrong force-pushed the maxime/update-tableau-docs-with-refresh-and-materialization branch from fb3baa3 to 3f66753 Compare October 2, 2024 19:39
@maximearmstrong maximearmstrong force-pushed the maxime/implement-tableau-refreshable-workbooks branch from f764c68 to a805ad2 Compare October 2, 2024 19:56
@maximearmstrong maximearmstrong force-pushed the maxime/update-tableau-docs-with-refresh-and-materialization branch from 3f66753 to 4fb4cdf Compare October 2, 2024 19:56
@maximearmstrong maximearmstrong force-pushed the maxime/implement-tableau-refreshable-workbooks branch from a805ad2 to 3c010c6 Compare October 3, 2024 17:56
@maximearmstrong maximearmstrong force-pushed the maxime/update-tableau-docs-with-refresh-and-materialization branch from 4fb4cdf to c9cbeb5 Compare October 3, 2024 17:56
@maximearmstrong maximearmstrong force-pushed the maxime/implement-tableau-refreshable-workbooks branch from 3c010c6 to 1ddbbaa Compare October 3, 2024 18:33
@maximearmstrong maximearmstrong force-pushed the maxime/update-tableau-docs-with-refresh-and-materialization branch 2 times, most recently from 107748d to 85af2a8 Compare October 3, 2024 18:35
@maximearmstrong maximearmstrong force-pushed the maxime/implement-tableau-refreshable-workbooks branch from 8dfb00b to f0bb010 Compare October 3, 2024 19:16
@maximearmstrong maximearmstrong force-pushed the maxime/update-tableau-docs-with-refresh-and-materialization branch from 85af2a8 to b954994 Compare October 3, 2024 19:16
Base automatically changed from maxime/implement-tableau-refreshable-workbooks to master October 4, 2024 01:40
@cmpadden cmpadden mentioned this pull request Oct 18, 2024
Closed
@github-actions GitHub Actions
Copy link

Deploy preview for dagster-docs-beta ready!

Preview available at https://dagster-docs-beta-3q96ckvdf-elementl.vercel.app

Direct link to changed pages:

@cmpadden
Copy link
Contributor

Merged changes from #25369 to keep Graphite stack intact. Confirmed unit tests are running green:

============================================================= test session starts ==============================================================
platform darwin -- Python 3.11.7, pytest-8.3.2, pluggy-1.5.0
rootdir: /Users/colton/src/dagster
configfile: pyproject.toml
plugins: syrupy-4.6.1, cov-5.0.0, time-machine-2.15.0, cases-3.8.5, buildkite-test-collector-0.1.8, rerunfailures-14.0, typeguard-4.3.0, anyio-4.4.0, mock-3.14.0, hypothesis-6.111.0, xdist-3.6.1, requests-mock-1.12.1
collected 15 items

dagster_tableau_tests/test_asset_specs.py ....                                                                                           [ 26%]
dagster_tableau_tests/test_pending_repo.py ..                                                                                            [ 40%]
dagster_tableau_tests/test_resources.py ....                                                                                             [ 66%]
dagster_tableau_tests/test_translator.py ....                                                                                            [ 93%]
dagster_tableau_tests/test_version.py .                                                                                                  [100%]

============================================================= 15 passed in 13.11s ==============================================================

@cmpadden cmpadden dismissed PedramNavid’s stale review October 18, 2024 18:16

Feedback has been addressed, thank you.

C00ldudeNoonan
C00ldudeNoonan approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@C00ldudeNoonan C00ldudeNoonan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, the api references will help users understand what they need to do.

@C00ldudeNoonan C00ldudeNoonan merged commit 9811d73 into master Oct 18, 2024
5 checks passed
@C00ldudeNoonan C00ldudeNoonan deleted the maxime/update-tableau-docs-with-refresh-and-materialization branch October 18, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C00ldudeNoonan C00ldudeNoonan C00ldudeNoonan approved these changes

@benpankow benpankow Awaiting requested review from benpankow

@sryza sryza Awaiting requested review from sryza

@cmpadden cmpadden Awaiting requested review from cmpadden

@PedramNavid PedramNavid Awaiting requested review from PedramNavid

Assignees

@maximearmstrong maximearmstrong

Labels
area: docs Related to documentation in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maximearmstrong @cmpadden @PedramNavid @C00ldudeNoonan