Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ui] Fix code location page status filters (#25229)
## Summary & Motivation Fix `useCodeLocationPageFilters` when an invalid query param is used. - If `status` is a non-array string, discard it. (This is the bug that was reported, where perhaps the user just modified the URL manually?) - Use a query parameter array instead of JSON encoding. ## How I Tested These Changes View code location list, filter on status. Verify that it works correctly and updates the URL accordingly, e.g. `?status%5B%5D=Loaded&status%5B%5D=Failed`. Modify the parameter manually to be `?status=failed`, verify that the page loads correctly with no JS errors, and ignores the invalid parameter. ## Changelog [ui] Fix an issue in the code locations page where invalid query parameters could crash the page.
- Loading branch information
f7d0b30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagit-core-storybook ready!
✅ Preview
https://dagit-core-storybook-gsw0rh3hd-elementl.vercel.app
Built with commit f7d0b30.
This pull request is being automatically deployed with vercel-action