Skip to content

Commit

Permalink
feat(config): enable assets_directory as config option in pyproject.toml
Browse files Browse the repository at this point in the history
  • Loading branch information
dbrtly committed Oct 19, 2024
1 parent d2ec720 commit c4dac17
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
2 changes: 2 additions & 0 deletions python_modules/dagster/dagster/_cli/workspace/cli_target.py
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ def get_workspace_load_target(kwargs: ClickArgMapping) -> WorkspaceLoadTarget:
attribute=check.opt_str_elem(kwargs, "attribute"),
working_directory=working_directory,
location_name=None,
assets_directory=None,
)
else:
# multiple modules
Expand All @@ -217,6 +218,7 @@ def get_workspace_load_target(kwargs: ClickArgMapping) -> WorkspaceLoadTarget:
attribute=None,
working_directory=working_directory,
location_name=None,
assets_directory=None,
)
for module_name in module_names
]
Expand Down
3 changes: 3 additions & 0 deletions python_modules/dagster/dagster/_core/workspace/load_target.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ def get_origins_from_toml(
attribute=None,
working_directory=os.getcwd(),
location_name=dagster_block.get("code_location_name"),
assets_directory=None,
).create_origins()
elif "modules" in dagster_block and is_valid_modules_list(dagster_block.get("modules")):
origins = []
Expand All @@ -110,6 +111,7 @@ def get_origins_from_toml(
attribute=None,
working_directory=os.getcwd(),
location_name=dagster_block.get("code_location_name"),
assets_directory=dagster_block.get("assets_directory" , "assets"),
).create_origins()
)
return origins
Expand Down Expand Up @@ -153,6 +155,7 @@ class ModuleTarget(
("attribute", Optional[str]),
("working_directory", Optional[str]),
("location_name", Optional[str]),
("assets_directory", Optional[str]),
],
),
WorkspaceLoadTarget,
Expand Down

0 comments on commit c4dac17

Please sign in to comment.