Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix column computation in documentation #44

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix column computation in documentation #44

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd0c4b4
Fix find_column() documentation comment.
alberth Feb 3, 2020
1bdec83
Fix off-by-one column computation for all but first line.
alberth Feb 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions docs/sly.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,13 +301,11 @@ column information as a separate step. For instance, you can search
backwards until you reach the previous newline::

# Compute column.
# input is the input text string
# text is the input text string
# token is a token instance
def find_column(text, token):
last_cr = text.rfind('\n', 0, token.index)
if last_cr < 0:
last_cr = 0
column = (token.index - last_cr) + 1
column = token.index - last_cr
return column

Since column information is often only useful in the context of error
Expand Down