Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dCache's 'DirectoryStream' with Java's 'DirectoryStream' #7262

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

LukasMansour
Copy link
Member

@LukasMansour LukasMansour commented Aug 1, 2023

Motivation:
Closes #3821

Modification:
Replaces dCache's old 'DirectoryStream' with Java's 'DirectoryStream'.

Removing dCache's old DirectoryStream results in some empty IOException catch-blocks that shouldn't be throwable...

Result:
The returned Streams of DirectoryEntry are now always a type of JDK's NIO DirectoryStream<DirectoryEntry>, dCache's custom DirectoryStream is removed. There are some empty (throw RuntimeException) blocks for IOExceptions that are not throwable. They appear since the JDK Interface Closable defines a close()-method with an IOException Throwable. and DirectoryStream inherits from Closable.

Signed-off-by: Lukas Mansour [email protected]

@LukasMansour LukasMansour changed the title Make dCache's 'DirectoryStream' an instance of Java's 'DirectoryStream' Replace dCache's 'DirectoryStream' with Java's 'DirectoryStream' Aug 3, 2023
@LukasMansour LukasMansour marked this pull request as ready for review August 3, 2023 08:40
# Conflicts:
#	modules/dcache-bulk/src/main/java/org/dcache/services/bulk/job/AbstractRequestContainerJob.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace custom org.dcache.util.list.DirectoryStream with java.nio.file.DirectoryStream
1 participant