fix: request proxy only after registering redis pubsub event listeners #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when requesting a proxy from a local redis instance it would sometimes not give a proxy but instead get the client stuck in the
onProxyOffer
client method. This would not happen with a remote redis instance, because there was a slight delay between asking redis for a proxy link and registering the event listeners.Fix: move the "ask for a proxy link" call two lines down, so that the pubsub event listeners are registered before asking redis for a proxy link.