Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: request proxy only after registering redis pubsub event listeners #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ThomasSelvig
Copy link

Previously, when requesting a proxy from a local redis instance it would sometimes not give a proxy but instead get the client stuck in the onProxyOffer client method. This would not happen with a remote redis instance, because there was a slight delay between asking redis for a proxy link and registering the event listeners.
Fix: move the "ask for a proxy link" call two lines down, so that the pubsub event listeners are registered before asking redis for a proxy link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant