Fix fcs multisearch (row limit) plus some refact.

czcorpus · Oct 6, 2023 · e9913e7 · e9913e7
1 parent ad8e5dc
commit e9913e7
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 6 deletions.
diff --git a/lib/action/model/fcs.py b/lib/action/model/fcs.py
@@ -40,6 +40,10 @@
 
 @dataclass
 class FCSResourceInfo:
+    pid: str
+    """
+    pid should be a universaly accepted persistent identifier (Handle.Net, DOI etc.)
+    """
     title: str
     landing_page_uri: Optional[str] = None
     language: Optional[str] = None
@@ -100,6 +104,7 @@ async def corpora_info(self, value: str, max_items: int) -> List[FCSResourceInfo
                     lang_code = get_lang_code(a2=cinfo.collator_locale.split('_')[0])
                 resources.append(
                     FCSResourceInfo(
+                        pid=corpus_id, # TODO we need something like an ID from Handle.Net or DOI
                         title=corpus_id,
                         description=cinfo.localized_desc('en'),
                         landing_page_uri=cinfo.web,
@@ -215,7 +220,7 @@ async def fcs_search(
         try:
             with plugins.runtime.AUTH as auth:
                 anon_id = auth.anonymous_user(self.plugin_ctx)['id']
-            q = ['q' + rq]
+            q = ('q' + rq,)
 
             # try to locate concordance in cache
             lock = asyncio.Lock()

diff --git a/lib/plugin_types/corparch/corpus.py b/lib/plugin_types/corparch/corpus.py
@@ -197,6 +197,7 @@ class   CorpusInfo:
     """
 
     id: Optional[str] = None
+    pid: Optional[str] = None # TODO see https://github.com/czcorpus/kontext/issues/6039
     name: Optional[str] = None
     description: Optional[str] = None  # filled in during localization
     _description_cs: Optional[str] = None

diff --git a/lib/views/fcs.py b/lib/views/fcs.py
@@ -17,8 +17,8 @@
 from collections import defaultdict
 from dataclasses import asdict, dataclass, field
 from typing import Any, Dict, List, Optional, Tuple
+import random
 
-import aiofiles
 import plugins
 import settings
 from action.argmapping.conc import QueryFormArgs
@@ -78,6 +78,7 @@ async def op_explain(amodel: FCSActionModel, req: KRequest, resp_common: FCSResp
                     lang_code = get_lang_code(a2=cinfo.collator_locale.split('_')[0])
                 resp['resources'].append(
                     FCSResourceInfo(
+                        pid=corp, # TODO we need something like an ID from Handle.Net or DOI
                         title=corp,
                         description=cinfo.localized_desc('en'),
                         landing_page_uri=cinfo.web,
@@ -159,9 +160,12 @@ async def op_search_retrieve(amodel: FCSActionModel, req: KRequest, resp_common:
     ]
     results: List[List[FCSSearchResult], str] = await asyncio.gather(*tasks)
     # merging results
+    merged_rows = [row for result, _ in results for row in result.rows]
+    if len(merged_rows) > resp_common.maximumRecords:
+        merged_rows = random.sample(merged_rows, k=resp_common.maximumRecords)
     merged_results = FCSSearchResult(
-        rows=[row for result, _ in results for row in result.rows],
-        size=sum(r.size for r, _ in results),
+        rows=merged_rows,
+        size=len(merged_rows),
     )
     cql_query = results[0][1]
 

diff --git a/templates/fcs/v1_complete.html b/templates/fcs/v1_complete.html
@@ -64,7 +64,7 @@
             </ed:SupportedDataViews>
             <ed:Resources>
                 {% for resource in resources %}
-                <ed:Resource>
+                <ed:Resource pid="{{ resource.pid }}">
                     <ed:Title xml:lang="en">{{ resource.title }}</ed:Title>
                     {% if resource.description %}
                     <ed:Description xml:lang="en">{{ resource.description }}</ed:Description>
@@ -134,7 +134,8 @@
             <sru:recordSchema>http://clarin.eu/fcs/resource</sru:recordSchema>
             <sru:recordPacking>{{ recordPacking }}</sru:recordPacking>
             <sru:recordData>
-                <fcs:Resource xmlns:fcs="http://clarin.eu/fcs/resource" pid="{{ corppid }}" ref="{{ conc_view_url_tpl }}{{ corppid }}">
+                <fcs:Resource xmlns:fcs="http://clarin.eu/fcs/resource"
+                              {% if corppid %} pid="{{ corppid }}" ref="{{ conc_view_url_tpl }}{{ corppid }}" {% endif %}>
                     <fcs:DataView type="application/x-clarin-fcs-hits+xml">
                         <hits:Result xmlns:hits="http://clarin.eu/fcs/dataview/hits">
                             {{ left|xmle }}<hits:Hit>{{ word|xmle }}</hits:Hit> {{ right|xmle }}