Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contact menu item with smooth scrolling for #links #297

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

maxkfranz
Copy link
Member

General information

Associated issues: N/A

Checklist

Author:

  • One or more reviewers have been assigned.
  • M/A Automated tests have been included in this pull request, if possible, for the new feature(s) or bug fix.
  • The associated GitHub issues are included (above).
  • Notes have been included (below).

Reviewers:

  • All automated checks are passing (green check next to latest commit).
  • At least one reviewer has signed off on the pull request. Reviewers have two business days to review the pull request, after which the author may merge in the pull request unilaterally.

Notes

  • Adds a 'Contact' menu item at the top of the page so it's easy for users to get in touch
  • The Contact link opens baderlab.org in a new tab
  • The hash section links like #faq now scroll smoothly so users know that sections like that are just found down the page. Otherwise, it looks like a new page when you click FAQ. This feature can be easily be turned off with a flag if we don't decide it's not needed.
Screen.Recording.2024-06-13.at.16.30.27.mov

@maxkfranz maxkfranz merged commit 8d9a58e into develop Jun 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants