Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop Tooltip component from creating empty div #265

Merged
merged 9 commits into from
Jun 22, 2023
Merged

Stop Tooltip component from creating empty div #265

merged 9 commits into from
Jun 22, 2023

Conversation

elevatebart
Copy link
Collaborator

@elevatebart elevatebart commented Jun 22, 2023 •
edited
Loading

closes #263
closes #260

also add forceOpen for development and design

@elevatebart elevatebart linked an issue Jun 22, 2023 that may be closed by this pull request
Tooltip component creates empty div #263
Closed
@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 1f23f49

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@cypress-design/react-tooltip Minor
@cypress-design/vue-tooltip Minor
@cypress-design/react-modal Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cypress-design ✅ Ready (Inspect) Visit Preview Jun 22, 2023 4:13pm

@elevatebart elevatebart changed the title 263-tooltip-component-creates-empty-div Stop Tooltip component from creating empty div Jun 22, 2023
@elevatebart elevatebart merged commit a69b7ee into main Jun 22, 2023
@elevatebart elevatebart deleted the 263-tooltip-component-creates-empty-div branch June 22, 2023 16:37
@github-actions github-actions bot mentioned this pull request Jun 22, 2023
Merged
@jaimefps
Copy link

@elevatebart Seems that version 0.7.0 never was published? When I try to install it says that only 0.5.4 is available?

@jaimefps
Copy link

Screen Shot 2023-07-18 at 1 58 55 PM

@elevatebart
Copy link
Collaborator Author

I believe it is published.

https://www.npmjs.com/package/@cypress-design/react-tooltip?activeTab=versions

@jaimefps
Copy link

I believe it is published.

https://www.npmjs.com/package/@cypress-design/react-tooltip?activeTab=versions

My mistake was that I confused @cypress/react-tooltip and @cypress-design/react-tooltip, came back to it now and was able to install, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tooltip component creates empty div Tooltip force open prop
2 participants
@elevatebart @jaimefps