move tooltip placement in a shared package

cypress-io · Jun 23, 2023 · e2a5148 · e2a5148
1 parent 40ab7c8
commit e2a5148
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 117 deletions.
diff --git a/components/Tooltip/vue/Tooltip.vue b/components/Tooltip/vue/Tooltip.vue
@@ -1,6 +1,6 @@
 <script lang="ts" setup>
 import type { Placement } from '@floating-ui/dom'
-import useTooltips from './useTooltip'
+import useTooltips from '@cypress-design/place-floating-vue'
 import type { Ref } from 'vue'
 import { watch, computed, ref, onBeforeMount, onMounted } from 'vue'
 

diff --git a/components/Tooltip/vue/package.json b/components/Tooltip/vue/package.json
@@ -20,7 +20,7 @@
     "build:types": "yarn vue-tsc --project ./tsconfig.build.json"
   },
   "dependencies": {
-    "@floating-ui/dom": "^1.4.2"
+    "@cypress-design/place-floating-vue": "*"
   },
   "devDependencies": {
     "@cypress-design/rollup-plugin-tailwind-keep": "*"

diff --git a/components/Tooltip/vue/useTooltip.ts b/components/Tooltip/vue/useTooltip.ts
diff --git a/packages/place-floating-vue/index.ts b/packages/place-floating-vue/index.ts
@@ -1,4 +1,4 @@
-import { type Ref, computed, ref } from 'vue'
+import { Ref, computed, ref } from 'vue'
 import type { Placement, Side } from '@floating-ui/dom'
 import { computePosition, flip, offset, arrow } from '@floating-ui/dom'
 

diff --git a/packages/place-floating-vue/rollup.config.mjs b/packages/place-floating-vue/rollup.config.mjs
@@ -27,4 +27,5 @@ export default {
       sourceMap: true,
     }),
   ],
+  external: ['@floating-ui/dom', 'vue'],
 }
diff --git a/yarn.lock b/yarn.lock
@@ -1002,13 +1002,6 @@
   dependencies:
     "@floating-ui/core" "^1.3.1"
 
-"@floating-ui/dom@^1.4.2":
-  version "1.4.2"
-  resolved "https://registry.yarnpkg.com/@floating-ui/dom/-/dom-1.4.2.tgz#eb3a37f7506c4f95ef735967dc3496b5012e11cb"
-  integrity sha512-VKmvHVatWnewmGGy+7Mdy4cTJX71Pli6v/Wjb5RQBuq5wjUYx+Ef+kRThi8qggZqDgD8CogCpqhRoVp3+yQk+g==
-  dependencies:
-    "@floating-ui/core" "^1.3.1"
-
 "@floating-ui/react-dom-interactions@^0.6.1":
   version "0.6.6"
   resolved "https://registry.yarnpkg.com/@floating-ui/react-dom-interactions/-/react-dom-interactions-0.6.6.tgz#8542e8c4bcbee2cd0d512de676c6a493e0a2d168"