Check for model initialization during eval #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarlinpe
reviewed
Oct 9, 2023
sarlinpe
reviewed
Oct 10, 2023
Co-authored-by: Paul-Edouard Sarlin <[email protected]>
sarlinpe
approved these changes
Oct 10, 2023
tompritch30
pushed a commit
to tompritch30/glue-factory
that referenced
this pull request
May 30, 2024
* Check for model initialization during eval * Change from warning to assert * change assertion to ValueError * fix isort and rename are_weights_initialized * cleanup set_initialized() * fix variable name bug * Make load_state_dict forward compatible Co-authored-by: Paul-Edouard Sarlin <[email protected]> * Remove unused imports --------- Co-authored-by: Paul-Edouard Sarlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseModel.load_state_dictto update a state variable whether a state dict is loadedBaseModel.is_initialized()checks 1) if all the modules of the current model are initialized 2) all submodels inherited from BaseModel are initialized.model.is_initialized()assertion to evalFixes #7