Adding basic CI and fixing minor problems #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create python-tests.yml Adding ceres and eigen dependencies Adding coverage Adding parameterized Fixing GPU torch problems Avoiding explicit transfer of the model to CUDA Adding tests for eval utils and standardizing the batched/non-batched behaviour (only tested with homographies) Testing failures in pytest Fixing dummy test Removing MishaKav/pytest-coverage-comment Fixing problems in MegaDepth evaluation Fixing division by 0 and converting function to torch Fixing lint errors Fixing isort errors
sarlinpe
reviewed
Oct 15, 2023
sarlinpe
reviewed
Oct 15, 2023
sarlinpe
reviewed
Oct 17, 2023
sarlinpe
reviewed
Oct 17, 2023
sarlinpe
approved these changes
Oct 18, 2023
tests/test_integration.py
Outdated
| @@ -0,0 +1,133 @@ | |||
| import logging | |||
|
Thanks for the review Paul! It is very cool that we have automatic tests, I will sleep better now 😅 |
tompritch30
pushed a commit
to tompritch30/glue-factory
that referenced
this pull request
May 30, 2024
* Adding integration tests Create python-tests.yml Adding ceres and eigen dependencies Adding coverage Adding parameterized Fixing GPU torch problems Avoiding explicit transfer of the model to CUDA Adding tests for eval utils and standardizing the batched/non-batched behaviour (only tested with homographies) Testing failures in pytest Fixing dummy test Removing MishaKav/pytest-coverage-comment Fixing problems in MegaDepth evaluation Fixing division by 0 and converting function to torch Fixing lint errors Fixing isort errors * Addressing PR comments * Addressing second round of PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains integration tests that check that LG and GS keep working and also fix some minor bugs:
confparameter fromeval_matches_homographyeval_matches_homography,eval_homography_robust,eval_homography_dlt.cuda()in the lightglue_pretrained constructorPlease check the code and just let me know if you agree with these changes 😃