-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't create files in /etc/iproute2 out of thin air #165
base: main
Are you sure you want to change the base?
Don't create files in /etc/iproute2 out of thin air #165
Conversation
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
I was not able to run your unit tests; I get a timeout after 10 minutes. Please let me know if it breaks anything else. I tested this using one of my own tests; it worked for me. Before patch:
After patch:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
==========================================
+ Coverage 50.48% 50.64% +0.15%
==========================================
Files 67 67
Lines 3207 3197 -10
==========================================
Hits 1619 1619
+ Misses 1362 1352 -10
Partials 226 226 ☔ View full report in Codecov by Sentry. |
Fixes: #164