Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy: do not fail the scan if clippy fails to install #174

Merged
merged 2 commits into from
Jun 19, 2024
Merged

clippy: do not fail the scan if clippy fails to install #174

merged 2 commits into from
Jun 19, 2024

Commits on Jun 19, 2024

  1. clippy: rename install_clippy_hook -> inject_clippy_hook 

    The name was confusing because, when the hook is triggered, clippy has
already been installed by dnf/rpm.
    @kdudka
    kdudka committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    bd4a143 View commit details
    Browse the repository at this point in the history

  2. clippy: do not fail the scan if clippy fails to install 

    If the `clippy` package is not available in the build repos, a warning
is emitted and `clippy` is not recorded as an enabled tool in the scan
properties.  But the scan continues without `clippy` in this case.

The approach is similar to what `--gcc-analyze` does.  This is needed
because `clippy` is not available for each mock config and we do not
want to configure the set of enabled tools separately for each mock
config.

Related: https://issues.redhat.com/browse/OSH-30
Closes: csutils#174
    @kdudka
    kdudka committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    69b366f View commit details
    Browse the repository at this point in the history