Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csmock: use Path.name to get the basename #172

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

lzaoral
Copy link
Member

@lzaoral lzaoral commented Jun 12, 2024

... and not Path.stem which also removes a filename suffix.

Fixes: b2c7201 ("csmock: use the root mock profile property for lock names")
Resolves: https://issues.redhat.com/browse/OSH-464

... and not `Path.stem` which also removes a filename suffix.

Fixes: b2c7201 ("csmock: use the root mock profile property for lock names")
Resolves: https://issues.redhat.com/browse/OSH-464
@lzaoral lzaoral requested a review from kdudka June 12, 2024 13:28
Copy link
Member

@kdudka kdudka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@lzaoral lzaoral merged commit 722830c into csutils:main Jun 12, 2024
34 of 36 checks passed
@lzaoral lzaoral deleted the fix-locks branch June 12, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants