-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust-clippy: fixes #164
rust-clippy: fixes #164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thnak you, @petr-matousek The clippy plugin now works on RHEL 8 as well!
Remarks:
- nit: The commit message for c34fe3a looks incomplete. 🤔
- I have found out that if the conversion script fails,
csmock
will still exit with0
which is quite unexpected. Could you please fix that as well? Thank you!
fb2ebd6
to
67cdf36
Compare
b029d58
to
0b6b5dc
Compare
/packit rebuild-failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @petr-matousek!
walrus operator was introduced in Python 3.8 but we support distributions that have Python versions lower than that.
remove the workaround for the byte-compilation of python scripts in unversioned directories and replace it with the recommended approach from Fedora's Pyhon Packaging Guidelines.
Merging, thank you both! |
this is a follow up to #157