Fix logLevel check in chart #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AKamyshnikova
commented
May 24, 2024
AKamyshnikova
commented
| Q | A |
|---|---|
| Bug fix? | [x] |
| New feature? | [] |
| API breaks? | [] |
| Deprecations? | [] |
| Related tickets | fixes #X, partially #Y, mentioned in #Z |
| License | Apache 2.0 |
|
Checked with e2e tests https://github.com/AKamyshnikova/casskop/actions/runs/9226953689 |
cscetbon
reviewed
Jun 5, 2024
| cassandraEnv = append(cassandraEnv, v1.EnvVar{ | ||
| Name: "JAVA_TOOL_OPTIONS", | ||
| Value: "-Dcom.sun.jndi.rmiURLParsing=legacy", | ||
| }) |
There was a problem hiding this comment.
It was already merged #143 - but gone missing in master brach - probably I made incorrect rebase
Set JAVA_TOOL_OPTIONS to -Dcom.sun.jndi.rmiURLParsing=legacy in order to run nodetool without passing address. Fixes: cscetbon#142
AKamyshnikova
force-pushed
the
logLevelFix
branch
from
6931a62
to
366d855
Compare
cscetbon
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.